Been on finasteride for last 4 years (had cystoscopy - "not concerning").
Seems to do the trick, but I have had frequent night urination for many decades. (Tried nettle pills with no effect - for nocturia -- frequent night urination). Maybe I just have a small bladder.
I really should give up all liquid intake by about 4 pm, but I find it v difficult to give up red wine to accompany supper.
Have tried milk thistle with no apparent difference.
If you are bald, an advantage of finasteride is that it encourages hair growth (there's a connection between finasteride and rogaine.) After 4 years, I am looking more and more like Santa Claus.