Please do some research. I will not do it for you anymore. Certain States have different time limits as you state in your post, yet certain States have what is called Tolling and certain crimes due to certain factors can have the pause button pushed to stop the countdown of time and then restart the time later. These charges Trump is facing are not class A felonies where there is no time limit in New York. However, the mitigating circumstances such as not being able to charge a sitting president activate the Tolling issue and stop the time.
Basically the charging time will have started upon his leaving office.
Yet that will be brought up in pre-trial events with the judge. Until then he has been arrested and indicted.
https://www.lawinfo.com/resources/criminal-defense/criminal-statute-limitations-time-limits.html
In other jurisdictions, states rely on a classification system for felonies and utilize that in administering the statutes of limitations laws. For instance, New York does not have a statute of limitations for first-degree murder, rape, and Class A felonies. Beyond that, their statutes of limitations are complex and depend on the particular set of circumstances in each case.