as to whether was Thaksin a good leader, I think it is safe to say that he was not the worst. ths military elite rule has hurt.
As to Generals making billions it is easy. First, they all come from families that are well if not military hierarchy. They pay for nothing. So they can invest their money.
I am sure that a certain portion of the cost of things sees its way to their pockets.